Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests, wires, and endianness #6

Merged
merged 18 commits into from
Jun 5, 2024
Merged

Conversation

WrathfulSpatula
Copy link
Collaborator

@WrathfulSpatula WrathfulSpatula commented Jun 4, 2024

This PR fixes wire map parsing and "endianness" conventions. It also adds a full suite of unit tests for the Catalyst Qrack device back end.

@vprusso
Copy link
Contributor

vprusso commented Jun 4, 2024

Hmm, it looks like we have some failing unit tests here:
https://github.com/unitaryfund/pennylane-qrack/actions/runs/9374095130/job/25809366794?pr=6

@WrathfulSpatula
Copy link
Collaborator Author

Hmm, it looks like we have some failing unit tests here:
https://github.com/unitaryfund/pennylane-qrack/actions/runs/9374095130/job/25809366794?pr=6

@vprusso I think it's due to OpenCL-detection problems (where the CI has no GPU). The last commit attempts to address it.

@WrathfulSpatula
Copy link
Collaborator Author

So, there was also the issue I mentioned, which should now be fixed, but the other problem is the version of catalyst against which we interface and statically link.

All unit tests pass locally, with the v0.7 release of Catalyst. The (other) problem seems to be that I never finished implementing Catalyst installation from source in the Git workflow for unit tests.

@WrathfulSpatula
Copy link
Collaborator Author

Here's the problem: I think we need v0.7 of Catalyst. This is on head of main branch of Catalyst. However, there's no feasibility to building Catalyst from source on CI/CD.

Unfortunately, the CI just has to fail, for now. This should likely be fixed when Catalyst v0.7 is released. Anyone reviewing can test, the unit tests will pass, running locally.

@WrathfulSpatula
Copy link
Collaborator Author

I have also verified, locally, that I receive the same test failures if I check out the v0.6 tag commit of Catalyst and build and install it. There's no way around this: it seems we need the v0.7 release.

@WrathfulSpatula WrathfulSpatula merged commit 176e3df into master Jun 5, 2024
1 of 4 checks passed
@WrathfulSpatula WrathfulSpatula deleted the wires_and_endianness branch June 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants